Ivan Tham
8985c58fd3
Add infobox
2021-07-04 18:01:59 +09:00
Gokul Soumya
c68fe1f2a3
Add object selection (textobjects) ( #385 )
...
* Add textobjects for word
* Add textobjects for surround characters
* Apply clippy lints
* Remove ThisWordPrevBound in favor of PrevWordEnd
It's the same as PrevWordEnd except for taking the current char
into account, so use a "flag" to capture that usecase
* Add tests for PrevWordEnd movement
* Remove ThisWord* movements
They did not preserve anchor positions and were only used
for textobject boundary search anyway so replace them with
simple position finding functions
* Rewrite tests of word textobject
* Add tests for surround textobject
* Add textobject docs
* Refactor textobject word position functions
* Apply clippy lints on textobject
* Fix overflow error with textobjects
2021-07-03 10:07:49 +09:00
Nathan Vegdahl
28d2d68804
Make horizontal selection movement work properly.
2021-07-02 09:51:29 -07:00
Kirawi
c5b2973739
:reload
(#374 )
...
* reloading functionality
* fn with_newline_eof()
* fmt
* wip
* wip
* wip
* wip
* moved to core, added simd feature for encoding_rs
* wip
* rm
* .gitignore
* wip
* local wip
* wip
* wip
* no features
* wip
* nit
* remove simd
* doc
* clippy
* clippy
* address comments
* add indentation & line ending change
2021-07-02 23:54:50 +09:00
Nathan Vegdahl
2224a1527e
Merge branch 'master' into great_line_ending_and_cursor_range_cleanup
2021-07-01 19:37:28 -07:00
Nathan Vegdahl
0b2d51cf5a
Fix unused Result
warnings in helix-term.
2021-07-01 19:06:52 -07:00
Nathan Vegdahl
efa3389b6a
Fix unused variable, parameter, and mut
warnings in helix-term.
2021-07-01 19:06:52 -07:00
Nathan Vegdahl
702a0491db
Remove #[allow(unused)] from helix-term, and fix unused imports.
...
Lots of other warning still left. Will address in subsequent commits.
2021-07-01 19:06:52 -07:00
Nathan Vegdahl
e725957704
Ensure a minimum selection width on commands that need it.
2021-07-01 14:22:28 -07:00
Nathan Vegdahl
7c7be6d583
Make Selection
's normalize and transform methods self-consuming only.
2021-07-01 14:22:28 -07:00
Nathan Vegdahl
0ae522f3df
Clean up Selection
to not use so many allocations.
2021-07-01 14:22:28 -07:00
Blaž Hrastnik
2a92dd8d4d
If completion arrives after we already stopped editing, ignore it
2021-06-30 17:49:42 +09:00
Joe Neeman
b39e452d77
Make set_unmodified an enum.
2021-06-30 17:08:50 +09:00
Joe Neeman
2902a10a3e
Make Document's format API a little nicer.
2021-06-30 17:08:50 +09:00
Joe Neeman
ffa2f2590b
Satisfy clippy.
2021-06-30 17:08:50 +09:00
Joe Neeman
d64d75e724
Add some async job infrastructure.
2021-06-30 17:08:50 +09:00
Joe Neeman
c9be480bf8
Make formatting happen asynchronously.
2021-06-30 17:08:50 +09:00
PabloMansanet
de8745aea7
Incorporate long word commands into keymap
2021-06-30 00:56:19 +09:00
Blaž Hrastnik
6214d707f3
fix: Don't panic on Enter on an empty document.
...
Refs #386
2021-06-28 17:52:57 +09:00
Blaž Hrastnik
503ca112ae
fix: jumping to location did not convert the URI correctly
...
thus breaking Windows
2021-06-25 13:20:15 +09:00
Keith Simmons
4418e17547
reverse the dependency between helix-tui and helix-view ( #366 )
...
* reverse the dependency between helix-tui and helix-view by moving a fiew types to view
* fix tests
* clippy and format fixes
Co-authored-by: Keith Simmons <keithsim@microsoft.com>
2021-06-25 12:58:15 +09:00
Ivan Tham
c2b937481f
Fix goto line end
...
Should not goto newline.
2021-06-24 18:34:23 -07:00
Ivan Tham
10548bf0e3
Fix previous broken refactor key into helix-view
...
Need to be used for autoinfo
Revert "Revert "Refactor key into helix-view""
This reverts commit 10f9f72232
.
2021-06-25 00:39:03 +09:00
Kirawi
15ae2e7ef1
Update helix-term/src/commands.rs
...
Co-authored-by: Ivan Tham <pickfire@riseup.net>
2021-06-24 22:38:38 +09:00
Kirawi
7ae21b98ce
Update helix-term/src/commands.rs
...
Co-authored-by: Ivan Tham <pickfire@riseup.net>
2021-06-24 22:38:38 +09:00
Shafkath Shuhan
629df6124d
Blocking :wq
2021-06-24 22:38:38 +09:00
Nathan Vegdahl
8935e7a879
Fix open-new-line command for CRLF, as well as other bugs.
...
Fixes #363 .
I set out to fix issue #363 , but after fixing it discovered some
other things were wrong with the command while testing. In
summary:
- #363 was because it was still assuming a line ending width
of 1 char in its indexing calculations, even when actually
inserting CRLF.
- Aside from #363 , it actually needed to set `line_end_index`
to zero for *all* calculations that use it when line == 0,
but it was only doing so for a single calculation.
2021-06-24 18:25:56 +09:00
Blaž Hrastnik
0f55e67576
fix: ok, needs to be the end of the previous line
2021-06-24 01:35:36 +09:00
Blaž Hrastnik
7366fe81e0
open: Use the correct function
...
Still not correct but at least it doesn't append at EOF
2021-06-24 01:06:17 +09:00
Blaž Hrastnik
4ad7b61c69
fix: Better fix that also fixes crashes on o
2021-06-24 00:58:14 +09:00
Blaž Hrastnik
655c1aeb73
fix: panic on O at the start of the file ( fixes #354 )
2021-06-24 00:50:52 +09:00
Shafkath Shuhan
fd98e743e8
Handle non-UTF8 files
2021-06-23 15:40:27 +09:00
Nathan Vegdahl
848cc1b438
Fix extend_line() behavior.
...
It would always extend to the next line if the cursor was at the
end of the current line, even if the current line wasn't fully
selected yet.
2021-06-23 12:43:09 +09:00
Nathan Vegdahl
38bf9c2576
Missed some items in the CRLF PR.
2021-06-23 12:43:09 +09:00
Blaž Hrastnik
7511110d82
Fix build on master
2021-06-23 10:15:57 +09:00
Joe Neeman
fd1ae35051
Make the prompt callback take a Context.
2021-06-23 10:03:11 +09:00
Lionel Flandrin
16883e7543
Implement show_current_directory command
2021-06-22 19:20:51 -04:00
Lionel Flandrin
b56174d738
Implement change_current_directory command
2021-06-22 19:20:51 -04:00
Blaž Hrastnik
20f33ead67
minor: Remove old TODOs
2021-06-22 23:26:34 +09:00
Gokul Soumya
e0fd08d6df
Rename surround to match_mode
2021-06-22 14:27:51 +09:00
Gokul Soumya
753ed4cbc5
Add documentation for surround
2021-06-22 14:27:51 +09:00
Gokul Soumya
b00e9fc227
Handle line endings correctly in surround
2021-06-22 14:27:51 +09:00
Gokul Soumya
b79b5e66f2
Move match_bracket to mm
2021-06-22 14:27:51 +09:00
Gokul Soumya
13648d28b9
Add surround keybinds
2021-06-22 14:27:51 +09:00
Blaž Hrastnik
a70de6e980
Merge pull request #224 from helix-editor/line_ending_detection
...
Line ending detection
2021-06-22 11:09:19 +09:00
Nathan Vegdahl
a18d50b777
Add command to set the document's default line ending.
2021-06-21 12:36:01 -07:00
Nathan Vegdahl
7c4fa18764
Fix clippy warnings.
2021-06-21 12:02:44 -07:00
Nathan Vegdahl
d33355650f
Convert remaining commands to use the document's line ending setting.
2021-06-21 11:59:03 -07:00
Nathan Vegdahl
e436c30ed7
Make split_selection_on_newline command handle all line endings.
2021-06-21 11:22:07 -07:00
Nathan Vegdahl
23d6188535
Update replace
command to use document line ending setting.
2021-06-21 11:08:05 -07:00
Nathan Vegdahl
07e28802f6
Add function to get the line ending of a str slice.
...
This is needed in some places.
2021-06-21 10:29:29 -07:00
Nathan Vegdahl
714002048c
Don't need getters/setters for line_ending property.
...
It's plain-old-data. If we want to do fancier things later, it's
easy to switch back.
2021-06-21 09:52:21 -07:00
wojciechkepka
cc357d5096
Add progress spinners to status line
2021-06-21 12:59:06 +09:00
Nathan Vegdahl
e686c3e462
Merge branch 'master' of github.com:helix-editor/helix into line_ending_detection
...
Rebasing was making me manually fix conflicts on every commit, so
merging instead.
2021-06-20 16:09:14 -07:00
Nathan Vegdahl
4efd6713c5
Work on moving code over to LineEnding instead of assuming '\n'.
...
Also some general cleanup and some minor fixes along the way.
2021-06-20 15:33:02 -07:00
Blaž Hrastnik
eaf259f8aa
Fix build..
2021-06-20 23:40:48 +09:00
Blaž Hrastnik
f41688d960
Merge x
and X
2021-06-20 23:37:11 +09:00
Benoît CORTIER
f50261c944
Add mappable commands for system clipboard
...
System clipboard integration exists now in two favors: typable and
mappable.
Default mappings are:
- SPC p: paste clipboard after
- SPC P: paste clipboard before
- SPC y: join and yank selection to clipboard
- SPC Y: yank main selection to clipboard
- SPC R: replace selections by clipboard contents
2021-06-20 23:25:53 +09:00
Benoît CORTIER
a2b8cfca34
Add system clipboard yank and paste commands
...
This commit adds six new commands to interact with system clipboard:
- clipboard-yank
- clipboard-yank-join
- clipboard-paste-after
- clipboard-paste-before
- clipboard-paste-replace
- show-clipboard-provider
System clipboard provider is detected by checking a few environment
variables and executables. Currently only built-in detection is
supported.
`clipboard-yank` will only yank the "main" selection, which is currently the first
one. This will need to be revisited later.
Closes https://github.com/helix-editor/helix/issues/76
2021-06-20 23:25:53 +09:00
Jan Hrastnik
8634e04a31
added the line_end helper function
2021-06-20 02:22:10 +02:00
Jan Hrastnik
701eb0dd68
changed some hardcoded newlines, removed a else if in line_ending.rs
2021-06-20 01:24:36 +02:00
wojciechkepka
42e13bd542
Add :theme <name>
command
2021-06-20 00:07:13 +09:00
Blaž Hrastnik
10f9f72232
Revert "Refactor key into helix-view"
...
Did not use defaults when custom keymap was used
This reverts commit ca806d4f85
.
2021-06-19 23:59:19 +09:00
Jan Hrastnik
1e80fbb602
fix merge issue
2021-06-19 14:58:49 +02:00
Jan Hrastnik
cdd9347457
Merge remote-tracking branch 'origin/master' into line_ending_detection
2021-06-19 14:51:53 +02:00
Jan Hrastnik
97323dc2f9
ran cargo fmt
2021-06-19 14:05:11 +02:00
Jan Hrastnik
ecb884db98
added get_line_ending from pr comment
2021-06-19 14:03:14 +02:00
Ivan Tham
ca806d4f85
Refactor key into helix-view
...
Now also make use of Deserialize for Config.
2021-06-19 16:37:15 +09:00
Gokul Soumya
b1cb98283d
Fix indent regression issue with o, O
...
Indents were no longer respected with `o` and `O`. Using counts resulted
in multiple cursors in the same line instead of cursors on each line.
Introduced by 47d2e3ae
2021-06-18 21:30:58 +09:00
wojciechkepka
a6d39585d8
Add work_done_token
as parameter to lsp methods
2021-06-18 17:42:38 +09:00
Wojciech Kępka
41b07486ad
Fix expansion of ~
( #284 )
...
* Fix expansion of `~`, dont use directory relative to cwd.
* Add `expand_tilde`
* Bring back `canonicalize_path`, use `expand_tilde` to `normalize`
* Make `:open ~` completion work
* Fix clippy
* Fold home dir into tilde in Document `realitve_path`
2021-06-18 15:19:34 +09:00
Benoît CORTIER
8664d70e73
Replace Editor::current
by a macro
...
This is necessary to workaround ownership issues across function calls.
The issue notably arised when implementing the registers into `Editor`
and I was getting annoyed again when implementing copy/pasting into
system clipboard.
The problem is addressed by using macro calls instead of function calls.
There is no notable side effect.
2021-06-18 09:38:10 +09:00
Jan Hrastnik
8bccd6df30
applied changes from pr review
2021-06-17 13:49:50 +02:00
PabloMansanet
f7e00cf720
Configurable keys 2 (Mapping keys to commands) ( #268 )
...
* Add convenience/clarity wrapper for Range initialization
* Add keycode parse and display methods
* Add remapping functions and tests
* Implement key remapping
* Add remapping book entry
* Use raw string literal for toml
* Add command constants
* Make command functions private
* Map directly to commands
* Match key parsing/displaying to Kakoune
* Formatting pass
* Update documentation
* Formatting
* Fix example in the book
* Refactor into single config file
* Formatting
* Refactor configuration and add keymap newtype wrappers
* Address first batch of PR comments
* Replace FromStr with custom deserialize
2021-06-17 20:08:05 +09:00
Gokul Soumya
47d2e3aefa
Let o, O take counts for multiple cursors
2021-06-17 18:54:07 +09:00
Gokul Soumya
20d6b202d5
Fix cursor position bugs related to o and O
...
- `O` at the beginning of file didn't move cursor
- `o` and `O` messed up cursor position with multiple cursors
Fixes #127
2021-06-17 18:54:07 +09:00
Jan Hrastnik
9c3eadb2e4
fixed some problems from rebasing
2021-06-16 17:22:55 +02:00
Jan Hrastnik
7cf0fa05a4
doc.line_ending() now returns &'static str
2021-06-16 17:13:44 +02:00
Jan Hrastnik
a4f5a0134e
trying out line ending helper functions in commands.rs
2021-06-16 17:13:41 +02:00
Benoît CORTIER
6bdf609caa
Remove RwLock for registers
...
Registers are stored inside `Editor` and accessed without `RwLock`.
To work around ownership, I added a sister method to `Editor::current`:
`Editor::current_with_context`. I tried to modify `Editor::current`
directly but it's used at a lot of places so I reverted into this for
now at least.
2021-06-15 23:01:56 +08:00
Benoît CORTIER
6fb2d2679d
Use _impl
suffix instead of _
prefix
...
Helpers / internal implementations where using the `_` prefix.
However, this prefix also suppress unused warnings.
I suggest we use the `_impl` suffix instead.
2021-06-15 02:33:12 -04:00
Ivan Tham
05ed3e8fb8
Remove unused variables
2021-06-15 00:17:04 -04:00
Nathan Vegdahl
7c2fb92c91
Report indent style when calling indent-style with no arguments.
...
Also print an error message when the argument is malformed.
2021-06-14 20:33:42 -07:00
Nathan Vegdahl
d415a666fe
Address PR comments.
...
* Clean up "indent-style" command argument parsing.
* Adjust command's name to match the style of other commands.
* Add a "0" alias to the command, for tabs indent style.
2021-06-14 18:32:23 -07:00
Nathan Vegdahl
358ea6a37c
Implement command to change the indent-style setting of a document.
2021-06-14 18:32:23 -07:00
Blaž Hrastnik
e819121f6e
fix: wq/wqa functions need to wait for save to finish before closing
2021-06-15 01:02:32 +09:00
Andreas Liljeqvist
5d23667a26
fix offset by one problem in replace_with_yanked
2021-06-14 09:58:40 +09:00
Wojciech Kępka
df217f71c1
Fix wq
2021-06-13 20:48:18 +09:00
Wojciech Kępka
b9100fbd44
Fix clippy
2021-06-13 20:48:18 +09:00
Wojciech Kępka
52d3c29244
Deduplicate code
2021-06-13 20:48:18 +09:00
Wojciech Kępka
17c9a8499e
Add qa
and qa!
2021-06-13 20:48:18 +09:00
Wojciech Kępka
62e6232a32
Update write_all
2021-06-13 20:48:18 +09:00
Wojciech Kępka
d8b5d1181f
Add Copy
derive to PromptEvent
2021-06-13 20:48:18 +09:00
Wojciech Kępka
b500a2a138
commands: Add more write commands
2021-06-13 20:48:18 +09:00
Ivan Tham
9640ed1425
Add clarification to last buffer
2021-06-13 09:58:50 +09:00
Robin
9baf1ecc90
add symbol picker ( #230 )
...
* add symbol picker
use the lsp document_symbol request
* fix errors from merging in master
* add docs for symbol picker
2021-06-12 21:45:21 +09:00
Robin
44cc0d8eb0
add alternate file ( #223 )
...
* add alternate file
inspired by vim ctrl-6/kak ga commands. the alternate file is kept per view
* apply feedback from #223
* rename to last_accessed
* add ga doc
* add fail message for ga
2021-06-12 21:21:06 +09:00
Wojciech Kępka
c754df12b3
lsp: Check bounds when converting lsp positions ( #204 )
...
* lsp: Make position conversion funcs return `Option`
* Add tests
* Fixes
* Revert pos_to_lsp_pos to panic
2021-06-12 16:04:30 +09:00
Blaž Hrastnik
278361a086
Only auto-format for certain languages
...
Fixes #53
Fixes #207
2021-06-12 10:20:37 +09:00
Jakub Bartodziej
69fe46a122
Add :earlier and :later commands that can be used to navigate the full edit history. ( #194 )
...
* Disable deleting from an empty buffer which can cause a crash.
* Improve on the fix for deleting from the end of the buffer.
* Clean up leftover log.
* Avoid theoretical underflow.
* Implement :before which accepts a time interval and moves the editor to
the closest history state to the commit of the current time minus that
interval. Current time is now by default, or the commit time if :before
has just been used.
* Add :earlier an :later commands that can move through
the edit history and retrieve changes hidded by undoing
and commiting new changes. The commands accept a number
of steps or a time period relative to the currrent change.
* Fix clippy lint error.
* Remove the dependency on parse_duration, add a custom parser instead.
* Fix clippy errors.
* Make helix_core::history a public module.
* Use the helper for getting the current document and view.
* Handled some PR comments.
* Fix the logic in :later n.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Add an alias for :earlier.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Add an alias for later.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Run cargo fmt.
* Add some tests for earlier and later.
* Add more tests and restore the fix for later that diappeared somehow.
* Use ? instead of a match on an option.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Rename to UndoKind.
* Remove the leftover match.
* Handle a bunch of review comments.
* More systemd.time compliant time units and additional description for the new commands.
* A more concise rewrite of the time span parser using ideas from PR discussion.
* Replace a match with map_err().
Co-authored-by: Ivan Tham <pickfire@riseup.net>
Co-authored-by: Jakub Bartodziej <jqb@google.com>
Co-authored-by: Ivan Tham <pickfire@riseup.net>
2021-06-11 22:06:13 +09:00
PabloMansanet
86af55c379
Movement fixes, refactor and unit test suite ( #217 )
...
* Add convenience/clarity wrapper for Range initialization
* Test horizontal moves
* Add column jumping tests
* Add failing movement conditions for multi-word moves
* Refactor skip_over_next
* Add complex forward movement unit tests
* Add strict whitespace checks and edge case tests
* Restore formatting
* Remove unused function
* Add empty test case for deletion and fix nth_prev_word_boundary
* Add tests for backward motion
* Refactor word movement
* Address review comments and finish refactoring backwards move
* Finish unit test suite
* Fmt pass
* Fix lint erors
* Clean up diff restoring bad 'cargo fmt' actions
* Simplify movement closures (thanks Pickfire)
* Fmt pass
* Replace index-based movement with iterator based movement, ensuring that each move incurs a single call to the RopeSlice API
* Break down tuple function
* Extract common logic to all movement functions
* Split iterator helpers away into their own module
* WIP reducing clones
* Operate on spans
* WIP simplifying iterators
* Simplify motion helpers
* Fix iterator
* Fix all unit tests
* Refactor and simplify
* Simplify fold
2021-06-11 21:57:07 +09:00
Wojciech Kępka
0c2b99327a
commands: Handle t<ENTER>
as till newline
2021-06-11 18:34:46 +09:00
Robin van Dijk
c0d32707d0
move to first nonwhitespace on shift-i
...
This matches the behaviour in vim and kak
2021-06-10 22:02:38 +09:00
Ivan Tham
6b3c9d8ed3
Fix jump behavior, goto_implementation now jump
...
Better jump behavior since we override the first jump if it's on the
first document. At the same time, ctrl-i is now working with gd jumps.
2021-06-10 11:08:18 +08:00
Zheming Li
ae51065213
Support go to line 1
2021-06-08 17:27:21 +09:00
Wojciech Kępka
4e3a343602
Make r<ENTER>
work
2021-06-08 17:23:38 +09:00
Wojciech Kępka
81e02e1ba4
Remove unwanted as_str
2021-06-08 17:23:38 +09:00
Wojciech Kępka
c349ceb61f
Don't replace newlines
2021-06-08 17:23:38 +09:00
Wojciech Kępka
2e4a338944
Add bounds checks to replace
2021-06-08 17:23:38 +09:00
Wojciech Kępka
9c83a98469
commands: Replace all characters in selection
2021-06-08 17:23:38 +09:00
Wojciech Kępka
c978d811d9
Cleanup find_first_non_whitespace_char funcs
2021-06-08 17:22:37 +09:00
Wojciech Kępka
48df05b16d
commands: Add goto first non-whitespace char of line
2021-06-08 17:22:37 +09:00
Kirawi
b873fb9897
Fix Unicode ( #135 )
...
* init
* wip
* wip
* fix unicode break
* fix unicode break
* Update helix-core/src/transaction.rs
Co-authored-by: Benoît Cortier <benoit.cortier@fried-world.eu>
* clippy
* fix
* add changes
* added test
* wip
* wip
* wip
* wip
* fix
* fix view
* fix #88
Co-authored-by: Benoît Cortier <benoit.cortier@fried-world.eu>
2021-06-08 13:20:15 +09:00
Wojciech Kępka
c65b4dea09
commands: Add replace with yanked as R
2021-06-08 09:50:14 +09:00
Blaž Hrastnik
0201ef9205
ui: completion: Use the correct type_name
...
Fixes #166
2021-06-08 01:38:57 +09:00
Blaž Hrastnik
9821beb5c4
Make gh/gl extend selection in select mode
2021-06-07 23:32:44 +09:00
Benoît CORTIER
68affa3c59
Implement register selection
...
User can select register to yank into with the " command.
A new state is added to `Editor` and `commands::Context` structs.
This state is managed by leveraging a new struct `RegisterSelection`.
2021-06-07 21:52:09 +09:00
Blaž Hrastnik
8d6fad4cac
lsp: Provide workspace root on client.initialize()
2021-06-07 21:32:01 +09:00
Blaž Hrastnik
4f561e93b8
View mode: Use saturating_sub when calculating first_col
2021-06-07 09:29:21 +09:00
Blaž Hrastnik
01b1bd15a1
commands: use chars().count() over .len() on strings
2021-06-07 09:26:49 +09:00
Wojciech Kępka
16b1cfa3be
Add diagnostics keybindings
2021-06-07 09:11:52 +09:00
Ivan Tham
2066e866c7
Add spc w w for window mode
2021-06-07 09:08:08 +09:00
Ivan Tham
40744ce835
Add ctrl-w in insert mode
...
It seemed to panic when I pressed too many times, but that is from
lsp side.
2021-06-06 21:30:18 +09:00
Ivan Tham
8c2fa12ffc
Add window mode
...
Fix #93
2021-06-06 10:12:35 +09:00
ahkrr
444cd0b068
fix: make find_prev_char and till_prev_char work
...
Bevore this PR `commands::find_prev_char` and `commands::till_prev_char` were triggerable through keys
but `seach::find_nth_next()` was hardcoded in `_find_char`.
The passed `fn` was nerver used. With this PR the passed `fn` is used.
The change in search.rs resolves an off by one error in the behivor of `find_nth_prev`
2021-06-06 00:01:16 +09:00
Kirawi
c17dcb8633
Fixing Multiple Panics ( #121 )
...
* init
* wip
* wip
2021-06-05 12:49:19 +09:00
Antoni Stevenet
a1f4b8f92b
Add home-end keymaps, (as kakoune/vim do) ( #83 )
...
* add home-end keymaps
* implement extend methods for extend_line_start, extend_line_end
* add home-end mappings to keymaps.md
* add ^-$ extend mappings for extend mode
* pass cargo linter
2021-06-05 09:25:46 +09:00
notoria
adcfcf9044
Replace ^/$ with gh/gl
2021-06-04 17:26:16 +09:00
Blaž Hrastnik
4f0e3aa948
Implement gt/gm/gb, remap goto tYpe to gy
2021-06-04 15:47:29 +09:00
Blaž Hrastnik
bd4552cd2b
scroll: Fix the clamping
2021-06-04 11:36:28 +09:00
Blaž Hrastnik
8afd4e1bc2
Exit select mode on delete_selection
2021-06-04 11:03:40 +09:00
Kevin Sjöberg
fdb5bfafae
Limit goto count
...
Giving a goto count greater than the number of lines in the buffer
would cause Helix to panic.
2021-06-04 01:35:52 +09:00
Jakub Bartodziej
09a7db637e
Avoid theoretical underflow.
2021-06-03 23:23:23 +09:00
Jakub Bartodziej
31ed4db153
Clean up leftover log.
2021-06-03 23:23:23 +09:00
Jakub Bartodziej
3c5dfb0633
Improve on the fix for deleting from the end of the buffer.
2021-06-03 23:23:23 +09:00
Jakub Bartodziej
6cbc0aea92
Disable deleting from an empty buffer which can cause a crash.
2021-06-03 23:23:23 +09:00
Blaž Hrastnik
cbb3ebafdc
Support ctrl-f and ctrl-b to page up/down, fixes #41
2021-06-02 13:20:36 +09:00
Daichi Takamiya
4d12c7c3cf
Fix empty command cause panic
2021-06-02 10:55:32 +09:00
Blaž Hrastnik
ce25aa951e
Allow setting a filepath on :write
2021-06-01 17:26:03 +09:00
Blaž Hrastnik
d8e16554bf
Don't crash if no filename specified on open
2021-06-01 11:59:59 +09:00
Blaž Hrastnik
2c48d65b15
Format document on save
2021-05-30 00:00:15 +09:00
Blaž Hrastnik
094203c74e
Update deps, introduce the new tree-sitter lifetimes
2021-05-28 00:00:51 +09:00
Blaž Hrastnik
f1dc25a774
Support count for indent too
2021-05-19 00:37:01 +09:00
Blaž Hrastnik
4f335fabc8
Fix unindent to work with tabs, take a count
2021-05-19 00:35:33 +09:00
Blaž Hrastnik
9c24f1ec0e
Drop selection_lines completely, change move_line_start binding
2021-05-18 18:28:32 +09:00
Blaž Hrastnik
f99a683991
Fix crash if appending at end of line on the last line of the file
2021-05-18 18:17:14 +09:00
Blaž Hrastnik
5a245b83a0
Append :fmt as a separate history state
2021-05-18 17:53:00 +09:00
Blaž Hrastnik
54de768915
Fix crash if typing | (regex or) into the prompt.
...
Zero-width matches at the start of the file make no sense to us.
2021-05-16 18:58:43 +09:00
Blaž Hrastnik
5e6b46e7c5
Use array::IntoIter.
2021-05-15 10:52:07 +09:00
Blaž Hrastnik
354b822d21
Fix crash on xa<Enter> if we were on the last line.
2021-05-15 10:50:36 +09:00
Blaž Hrastnik
fae2127a11
Drop cx.view_id, it was used before we had cx.current.
2021-05-15 10:50:36 +09:00
Blaž Hrastnik
0e5b421646
When calculating a new selection, we need to take newly inserted text into account.
2021-05-15 10:50:36 +09:00
Blaž Hrastnik
4a9d1163e0
Hacky way to specify indent scopes per language via toml configs.
...
Can't do it via a scm query nicely because it returns an iterator over
all the matches, whereas we want to traverse the tree ourselves.
Can't extract the pattern data from a parsed query either.
Oh well, toml files for now.
2021-05-14 19:21:46 +09:00
Blaž Hrastnik
e4ff75b4d4
Add :fmt (formats the whole file).
2021-05-12 17:24:55 +09:00
Blaž Hrastnik
1255bcb8a3
Simplify the compositor callback.
2021-05-09 18:02:31 +09:00
Blaž Hrastnik
ed827e993f
Fix jumplist jumps, keep the selection on vsplit.
2021-05-08 18:25:19 +09:00
Blaž Hrastnik
caf4349925
Remove some of the panics, just log instead.
2021-05-08 18:17:13 +09:00
Blaž Hrastnik
d24844b73d
ui: Render command mode doc text if available.
2021-05-08 17:33:06 +09:00
Blaž Hrastnik
d4d5e88ade
Show a message if no definition was found.
2021-05-08 15:39:42 +09:00
Blaž Hrastnik
1be8b2005d
Extract a method for view alignment.
2021-05-08 15:36:27 +09:00
Blaž Hrastnik
adaf861881
vsplit can now split scratch buffers.
2021-05-08 15:29:15 +09:00
Blaž Hrastnik
ff84c8e394
Command mode: Per command completers.
2021-05-07 17:19:45 +09:00
Blaž Hrastnik
87e7a0de3f
Save space by having the command hashmap use const static refs.
2021-05-07 17:13:26 +09:00
Blaž Hrastnik
9604a0c294
Improve command mode handling.
2021-05-07 17:08:07 +09:00
Blaž Hrastnik
243456a583
Disallow quitting on last view if unsaved changes present.
2021-05-07 15:15:15 +09:00
Blaž Hrastnik
c0a8b81487
Only send the document close event if we're closing the underlying buffer
2021-05-07 14:52:47 +09:00
Blaž Hrastnik
c20813690f
View::new is infallible, so is editor.switch/new_file.
2021-05-07 14:45:49 +09:00
Blaž Hrastnik
f2c79e245b
Allow switching views back to scratch buffers.
2021-05-07 14:36:37 +09:00
Blaž Hrastnik
7c915dc065
Add the :new command, don't crash if saving without filename.
2021-05-07 14:19:58 +09:00
Blaž Hrastnik
f8844c6811
Implement pair expansion when pressing new line between bracket pairs.
...
From:
{|}
To:
{
|
}
2021-05-06 23:02:32 +09:00
Blaž Hrastnik
ba97005495
Work around the rest of the blocking issues.
2021-05-06 17:15:49 +09:00
Blaž Hrastnik
d00414f81a
Start moving more LSP calls into callbacks/futures without capturing self
2021-05-06 15:08:59 +09:00
Blaž Hrastnik
355ad3cb82
Tokio migration.
2021-05-06 13:56:34 +09:00
Blaž Hrastnik
0e5308bce1
Need to allow this lint, the Hook signature requires Option<>.
2021-05-05 16:25:17 +09:00
Blaž Hrastnik
ab4decfd6d
Make post hooks trigger even when a different handler processes input.
...
The default handler is now simply a fallback.
2021-05-03 17:56:02 +09:00
Blaž Hrastnik
594575ba3f
Center forward and backward jumps too.
2021-04-24 11:46:46 +09:00
Blaž Hrastnik
c64240b6ef
Implement most of the view mode (z).
2021-04-14 17:15:11 +09:00
Blaž Hrastnik
3e5f24a9d5
lsp: support both utf-8 and utf-16 offsets.
...
Still need to implement the clangd encoding negotiation, but it's
a start. Should also manually override to utf8 for pyls.
2021-04-14 15:39:31 +09:00
Blaž Hrastnik
811f952a41
Center search results.
2021-04-14 15:39:31 +09:00
Blaž Hrastnik
180521fefe
Adjust scroll() to match kakoune: only scroll the view if cursor in bounds.
2021-04-14 14:27:47 +09:00
Blaž Hrastnik
2a1f10d1b5
Center the new position on screen after doing a goto jump.
2021-04-13 16:56:03 +09:00
Blaž Hrastnik
95dd55ba94
Fix overlap calculation.
2021-04-10 12:02:23 +09:00
Blaž Hrastnik
392c4a9c02
Keep primary selection as space+space.
2021-04-10 00:21:54 +09:00
Blaž Hrastnik
73f4abbb37
N as extend with search (for now, N should be search_prev).
2021-04-10 00:21:13 +09:00
Blaž Hrastnik
865429643b
<space>w for save, <space>c for close current split.
2021-04-09 18:57:46 +09:00
Blaž Hrastnik
9ca2909c80
Loop around the end on regex searches.
2021-04-08 22:34:06 +09:00
Blaž Hrastnik
8b33ba2284
Correct the naming issue with vsplit and hsplit being swapped.
2021-04-08 15:52:04 +09:00
Blaž Hrastnik
58c5fec592
minor: This comment was resolved.
2021-04-08 14:25:04 +09:00
Blaž Hrastnik
12961d657f
Implement P as paste_before.
2021-04-07 17:03:29 +09:00
Blaž Hrastnik
82ff996662
Yank selection when deleting.
2021-04-07 15:40:15 +09:00
Blaž Hrastnik
463f58dfda
Fix clamping scroll in certain cases.
...
.clamp(min, max) requires that min < max. In some cases
first + scrolloff > last - scrolloff and we would panic.
2021-04-07 13:38:50 +09:00
Blaž Hrastnik
0e9ecccfc1
clippy: Drop or-patterns for now because they're not on stable rust yet
2021-04-06 19:51:15 +09:00
Blaž Hrastnik
95d0bba81a
ui: Improve completion state handling.
2021-04-05 18:23:37 +09:00
Blaž Hrastnik
59a0fc7b59
w, b, e: Match kakoune's behavior in selecting by default.
...
I initially preferred only moving the cursor, but selecting the whole
word is a lot nicer for things like wd (instead of vwd).
2021-04-05 16:35:04 +09:00
Blaž Hrastnik
ab1d11088f
Import some lsp utilities.
2021-04-01 11:43:34 +09:00
Blaž Hrastnik
77cab5a715
Merge open_above and open_below definitions.
2021-04-01 11:36:59 +09:00
Blaž Hrastnik
cc058ad78f
Simplify some code.
2021-04-01 11:04:25 +09:00
Blaž Hrastnik
0dbd5b61ef
Simplify code by providin cx.current() = (view, doc).
2021-04-01 11:01:26 +09:00
Blaž Hrastnik
ceea5eacd8
clippy lint
2021-03-31 23:42:16 +09:00
Blaž Hrastnik
7dfd7f51a0
Implement space-v as view same file in split.
2021-03-31 18:00:53 +09:00
Blaž Hrastnik
6c4093c946
Weave through view_id references so that views into one file have independent selects.
2021-03-31 17:17:01 +09:00
Blaž Hrastnik
dfc17becd5
Move pickers under my leader key mode (space).
2021-03-30 18:38:26 +09:00
Blaž Hrastnik
e166da2ab0
fix: A (append to line) was inserting before last char.
2021-03-30 18:31:56 +09:00
Blaž Hrastnik
1b5316ea74
Track document modified state.
2021-03-30 18:23:12 +09:00
Blaž Hrastnik
88bb7a1f38
Repeat insert command (.).
2021-03-30 18:19:27 +09:00
Blaž Hrastnik
e833d65b77
Teach file picker how to find the project root (.git).
2021-03-30 10:14:50 +09:00
Blaž Hrastnik
8098e9bdcd
Allow setting a status message.
2021-03-29 16:47:02 +09:00
Blaž Hrastnik
742b3a709f
Store intra-files jumps (goto) on the jumplist.
2021-03-29 16:32:42 +09:00
Blaž Hrastnik
0083a6c325
commands: Simplify _goto.
2021-03-29 15:44:03 +09:00
Blaž Hrastnik
ea407ccdba
Implement <n>g as goto line n.
2021-03-29 15:29:03 +09:00
Blaž Hrastnik
5c2d2fda21
Wire up opening in splits via pickers.
2021-03-29 15:21:48 +09:00
Blaž Hrastnik
aefafc25cd
Replace Mode::Goto with just using on_next_key.
2021-03-29 15:04:29 +09:00
Blaž Hrastnik
a24c3fff54
Filter the completion menu based on text entered.
2021-03-27 12:08:44 +09:00
Blaž Hrastnik
2a3910c1d9
wip: Async async. Delay response handling with a callback.
2021-03-26 17:12:45 +09:00
Blaž Hrastnik
ad3325db8e
minor: Remove a few unwraps.
2021-03-26 11:03:14 +09:00
Blaž Hrastnik
9a36d2c2a8
wip: Hooks & trigger characters for completion/signature_help.
2021-03-24 18:17:00 +09:00
Blaž Hrastnik
8657c57cf2
Trivial jumplist implementation.
2021-03-24 18:01:26 +09:00
Blaž Hrastnik
915fd9ebaf
Restore buffer_picker.
2021-03-24 16:26:53 +09:00
Blaž Hrastnik
8a0ab447ec
editor.open can now either replace the current view or open in a split.
2021-03-24 14:28:26 +09:00
Blaž Hrastnik
8328fe926d
Drop refcell use, make view simply ref doc.id.
2021-03-23 18:14:35 +09:00
Blaž Hrastnik
d0530fb839
Fix a scrolling crash where it would jump past the end of the buffer.
2021-03-22 18:06:52 +09:00
Blaž Hrastnik
73c92a0bc1
Implement m / match_brackets (using tree sitter).
2021-03-22 17:58:49 +09:00
Blaž Hrastnik
df306fe031
Implement open_above (O).
2021-03-22 13:53:43 +09:00
Blaž Hrastnik
42d07b0621
Implement replace command (r<key>).
2021-03-22 13:53:43 +09:00
Blaž Hrastnik
bf95ee27aa
Store Document on the Editor type, make View reference it.
2021-03-22 13:53:43 +09:00
Blaž Hrastnik
5e6716c89c
Add tab_width and indent_unit config.
2021-03-22 13:53:36 +09:00
Blaž Hrastnik
cbcacb1063
Merge some imports.
2021-03-22 12:40:07 +09:00
Blaž Hrastnik
71999cce43
Implement auto-pairs behavior for open and close.
2021-03-22 12:22:33 +09:00
Blaž Hrastnik
a32806b490
Improve completion: src/<tab> will now correctly complete to src/main.rs
2021-03-21 14:13:49 +09:00
Blaž Hrastnik
f29f01858d
Implement iter() and len() directly on Selection.
2021-03-19 11:14:13 +09:00
Blaž Hrastnik
e9bd9e72c3
Pos conversions always operate on whole documents.
2021-03-18 15:23:42 +09:00
Blaž Hrastnik
175d38c88c
toggle_comments needs to append to history.
2021-03-18 15:20:28 +09:00
Blaž Hrastnik
c331721565
Finish hiding doc.state / State as an implementation detail.
2021-03-18 15:07:02 +09:00
Blaž Hrastnik
8ba1e15d29
Expose doc.syntax() via accessor.
2021-03-18 14:53:29 +09:00
Blaž Hrastnik
e261f3c50d
Expose doc.language_server as an accessor.
2021-03-18 14:40:22 +09:00
Blaž Hrastnik
59e6024186
Remove State from a few more signatures.
2021-03-18 14:17:32 +09:00
Blaž Hrastnik
dbcc099f48
Move things out of state.rs.
2021-03-18 14:07:53 +09:00
Blaž Hrastnik
0f6624491b
Fix completion panicking if text changed before insert completed.
2021-03-18 14:07:53 +09:00
Blaž Hrastnik
8eaf9a432d
Make Transaction::change only rely on the rope.
2021-03-18 13:39:56 +09:00
Blaž Hrastnik
51c15da3c3
Hold a reference to executor on the Editor type.
2021-03-16 23:14:51 +09:00
Blaž Hrastnik
e3ec5e31ec
Fix goto code before merging.
2021-03-16 23:05:43 +09:00
Jan Hrastnik
eadad13efa
preparing for gd merge
2021-03-16 23:03:29 +09:00
Jan Hrastnik
4e461bea2f
editor.open now checks if view already exists
2021-03-16 23:03:29 +09:00
Jan Hrastnik
0828d1fdea
picker wip
2021-03-16 23:03:29 +09:00
Blaž Hrastnik
cf71625d4e
term: Simplify goto code, address lints.
2021-03-16 23:03:27 +09:00
Jan Hrastnik
3869d7713e
added goto functions in helix-term
2021-03-16 23:03:10 +09:00
Jan Hrastnik
b738ae1bc7
more goto lsp functions
2021-03-16 23:03:10 +09:00
Jan Hrastnik
294791dffd
added picker for gd, but yet to test it. also need to load appropriate file when definition isnt in same file
2021-03-16 23:03:10 +09:00
Jan Hrastnik
0322c28e6b
gd now works for singular definition
2021-03-16 23:03:10 +09:00
Blaž Hrastnik
18ec8adc7f
Simplify code a bit.
2021-03-16 23:03:10 +09:00
Jan Hrastnik
8a68a04340
gotodefiniton now runs but doesnt return anything
2021-03-16 23:03:10 +09:00
Jan Hrastnik
d3ddc8dea6
wip
2021-03-16 23:03:10 +09:00
Blaž Hrastnik
54a7e893b7
lsp: Wire up didClose notification on editor.close.
2021-03-16 16:27:12 +09:00
Blaž Hrastnik
eca2a73ad0
lsp: Pass through language_id on didOpenTextDocument.
2021-03-16 16:13:41 +09:00
Blaž Hrastnik
143cfe13e0
minor: TODO comment cleanup
2021-03-16 15:41:42 +09:00
Blaž Hrastnik
eea339545c
Add command for keeping only the primary selection.
2021-03-15 17:13:36 +09:00
Blaž Hrastnik
dd91090a1a
Implement keep_selections (filter selections on regex).
2021-03-15 17:09:18 +09:00
Blaž Hrastnik
1cf887dea9
Cleanup: use doc.selection() instead of doc.state.selection().
2021-03-14 17:14:34 +09:00
Blaž Hrastnik
4acf301022
Implement the f/t/F/T find/till family of commands.
2021-03-11 16:15:27 +09:00
Blaž Hrastnik
62c991230f
find-till (f) prototype, on_next_key mode implementation.
2021-03-11 10:44:38 +09:00
Blaž Hrastnik
5ea610c41d
ui: Move terminal into compositor, redo required_size hints.
2021-03-08 17:00:32 +09:00
Blaž Hrastnik
05aa0d6991
minor: dead code
2021-03-05 17:55:06 +09:00
Blaž Hrastnik
1d42b95915
ui: wip: Markdown doc renderer.
2021-03-05 16:07:46 +09:00
Blaž Hrastnik
a5c4314940
commands: Improve scroll functions.
...
Followed kakoune's implementation, it's no longer janky and can scroll
all the way in either direction.
2021-03-04 16:15:34 +09:00
Blaž Hrastnik
565fb94afe
commands: Correct another case that always used primary().
2021-03-04 14:12:19 +09:00
Blaž Hrastnik
7e4830215e
commands: w/b/e need to apply to all selections.
2021-03-04 14:09:39 +09:00
Blaž Hrastnik
4c6611f96b
commands: Stop select_regex from breaking when no matches.
2021-03-03 17:55:56 +09:00
Blaž Hrastnik
0b85c16be9
ui: Share popup code with menu.
...
Menu is now just wrapped in a popup.
2021-03-02 18:24:24 +09:00
Blaž Hrastnik
11c4e0b053
ui: Calculate popup rendering and sizing.
2021-03-02 17:58:15 +09:00
Blaž Hrastnik
8f4ff4c646
editor: We still want to be able to calculate cursor pos.
2021-03-02 15:44:09 +09:00
Blaž Hrastnik
32f9a2d1d6
add missing fn
2021-03-01 18:19:08 +09:00
Blaž Hrastnik
857bce0e30
ui: Rework command mode, implement file path completion.
2021-03-01 18:02:31 +09:00
Blaž Hrastnik
2088c45075
commands: Implement X as extend line.
2021-03-01 14:41:02 +09:00
Blaž Hrastnik
ec4dd0a176
Add a selection mode again.
2021-03-01 14:31:34 +09:00
Blaž Hrastnik
00808afe3c
ui: Make editor more resilient about being shrunk too small.
2021-03-01 14:23:10 +09:00
Blaž Hrastnik
2c9b02039b
commands: Implement join_selections.
2021-02-26 17:21:59 +09:00
Blaž Hrastnik
1ae7c43391
commands: = as range formatting (via lsp)
2021-02-26 15:52:43 +09:00
Blaž Hrastnik
7162632eb7
lsp: Hover documentation draft.
2021-02-25 18:07:47 +09:00
Blaž Hrastnik
8289bd1cb0
minor, fix clippy lint
2021-02-25 16:52:32 +09:00
Blaž Hrastnik
01907b3497
commands: Implement count for a few more commands.
2021-02-25 16:49:30 +09:00
Blaž Hrastnik
5fa1ba6b1c
commands: refactor open_below to support count.
2021-02-25 16:47:37 +09:00
Blaž Hrastnik
87a6d4e736
minor: Simplify some code.
2021-02-24 16:07:39 +09:00
Blaž Hrastnik
def949e509
open_below: drop redundant collect/into_iter.
2021-02-22 17:02:32 +09:00
Blaž Hrastnik
6cfb1acb9d
commands: Implement expand_selection.
2021-02-22 17:02:32 +09:00
Blaž Hrastnik
33c67f1388
commands: add * as selection search.
2021-02-22 15:14:02 +09:00
Blaž Hrastnik
5096bdad33
completion: Use the language server bound to the document.
2021-02-22 11:42:47 +09:00
Blaž Hrastnik
9132c6a591
Make some Document fields read-only.
2021-02-21 19:47:21 +09:00
Blaž Hrastnik
7da6bd6a71
commands: Simplify some code, only calling cx.doc() once.
2021-02-21 19:04:31 +09:00
Blaž Hrastnik
7877647cf0
Allow closing individual views.
2021-02-19 17:46:43 +09:00
Blaž Hrastnik
1e1dae1c11
Remove unused method.
2021-02-19 16:49:10 +09:00
Blaž Hrastnik
8c82f8f140
indent: use_list indentation, fix indentation bug on open_below
...
use std::{
time::Duration // <- pressing `o` here would use }'s indent instead of prev line
}
2021-02-19 14:55:53 +09:00
Blaž Hrastnik
7a1ff5e45f
commands: Wire up toggle comments as ctrl-c
2021-02-19 13:59:24 +09:00
Blaž Hrastnik
c9dd1c930e
treewide: &RopeSlice -> RopeSlice. It's Copy so no reason to pass by ref
2021-02-18 18:34:22 +09:00
Blaž Hrastnik
9cac44c7c0
minor changes
2021-02-17 17:26:27 +09:00
Blaž Hrastnik
c408e7e01a
commands: tie in a simple :w for now.
2021-02-16 18:23:44 +09:00
Blaž Hrastnik
83d48f10ea
search: Barebones implementation.
2021-02-12 18:10:05 +09:00
Blaž Hrastnik
239db79834
Finally: Retain horizontal position when moving vertically.
2021-02-12 16:49:24 +09:00
Blaž Hrastnik
d4b85ce18d
popup: wip work on completion popups
2021-02-09 15:40:47 +09:00
Blaž Hrastnik
30d1b7098f
commands: % as select_all.
2021-02-09 15:39:26 +09:00
Blaž Hrastnik
9c33b5340a
A dumb "next view" implementation that works.
2021-02-04 19:49:29 +09:00