andrey/helix-mirror
1
0
Fork 0
mirror of https://github.com/helix-editor/helix.git synced 2024-11-25 10:56:19 +04:00
Code Issues Projects Releases Wiki Activity

Remove TODO comment in helix_lsp::Registry::restart and add doc-comment on top of function instead

Browse Source
This commit is contained in:
Philipp Mildenberger 2023-04-05 18:10:49 +02:00
parent dcb07673f8
commit 521cdec5a1
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
helix-lsp/src/lib.rs
View File

@ -680,6 +680,9 @@ fn start_client(
Ok(client)
}
/// If this method is called, all documents that have a reference to language servers used by the language config have to refresh their language servers,
/// as it could be that language servers of these documents were stopped by this method.
/// See [helix_view::editor::Editor::refresh_language_servers]
pub fn restart(
&mut self,
language_config: &LanguageConfiguration,
@ -707,8 +710,6 @@ pub fn restart(
.insert(name.clone(), vec![client.clone()])
.unwrap();
// TODO what if there are multiple instances for different workspaces?
// I think the language servers will be stopped without being restarted, which is not intended
for old_client in old_clients {
tokio::spawn(async move {
let _ = old_client.force_shutdown().await;