From 521cdec5a1a53c61d38ce5a1df85f82857f59149 Mon Sep 17 00:00:00 2001 From: Philipp Mildenberger Date: Wed, 5 Apr 2023 18:10:49 +0200 Subject: [PATCH] Remove TODO comment in helix_lsp::Registry::restart and add doc-comment on top of function instead --- helix-lsp/src/lib.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/helix-lsp/src/lib.rs b/helix-lsp/src/lib.rs index 660825039..989c5e2fc 100644 --- a/helix-lsp/src/lib.rs +++ b/helix-lsp/src/lib.rs @@ -680,6 +680,9 @@ fn start_client( Ok(client) } + /// If this method is called, all documents that have a reference to language servers used by the language config have to refresh their language servers, + /// as it could be that language servers of these documents were stopped by this method. + /// See [helix_view::editor::Editor::refresh_language_servers] pub fn restart( &mut self, language_config: &LanguageConfiguration, @@ -707,8 +710,6 @@ pub fn restart( .insert(name.clone(), vec![client.clone()]) .unwrap(); - // TODO what if there are multiple instances for different workspaces? - // I think the language servers will be stopped without being restarted, which is not intended for old_client in old_clients { tokio::spawn(async move { let _ = old_client.force_shutdown().await;