andrey/retina
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove hack for GW Security cameras' audio channel

Browse Source 
This didn't work; I wasn't able to get working audio from them.
I'm not sure they even actually have a microphone! They may just
be sending uninitialized/stale buffer contents on this channel.

Just don't use the audio channel with this camera.
This commit is contained in:
Scott Lamb 2021-08-31 06:55:25 -07:00
parent 60a253073c
commit f356a16ba6
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/client/rtp.rs
View File

@ -95,19 +95,6 @@ impl InorderParser {
stream_id: usize, stream_id: usize,
mut data: Bytes, mut data: Bytes,
) -> Result<Option<PacketItem>, Error> { ) -> Result<Option<PacketItem>, Error> {
// Terrible hack to try to make sense of the GW Security GW4089IP's audio stream.
// It appears to have one RTSP interleaved message wrapped in another. RTP and RTCP
// packets can never start with '$', so this shouldn't interfere with well-behaved
// servers.
if data.len() > 4
&& data[0] == b'$'
&& usize::from(u16::from_be_bytes([data[2], data[3]])) <= data.len() - 4
{
log::debug!("stripping extra interleaved data header");
data.advance(4);
// also remove suffix? dunno.
}
let reader = rtp_rs::RtpReader::new(&data[..]).map_err(|e| { let reader = rtp_rs::RtpReader::new(&data[..]).map_err(|e| {
wrap!(ErrorInt::PacketError { wrap!(ErrorInt::PacketError {
conn_ctx: *conn_ctx, conn_ctx: *conn_ctx,