From cda6808ddaaf2567f868dc0a62314287344e2d4d Mon Sep 17 00:00:00 2001 From: Shehriyar Qureshi Date: Mon, 31 Oct 2022 20:36:28 +0500 Subject: [PATCH] refactor(h264): replace is_some with variants --- src/codec/h264.rs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/codec/h264.rs b/src/codec/h264.rs index c7f2cca..d6b405e 100644 --- a/src/codec/h264.rs +++ b/src/codec/h264.rs @@ -481,17 +481,16 @@ impl Depacketizer { return Err("FU-A pkt with MARK && !END".into()); } let u32_len = u32::try_from(data.len()).expect("RTP packet len must be < u16::MAX"); - match (start, access_unit.in_fu_a.is_some()) { - (true, true) => return Err("FU-A with start bit while frag in progress".into()), - (true, false) => { + match (start, access_unit.in_fu_a) { + (true, Some(_)) => { + return Err("FU-A with start bit while frag in progress".into()) + } + (true, None) => { self.nal_parser.start_rtp_nal(nal_header, data, u32_len)?; access_unit.in_fu_a = Some(nal_header); } - (false, true) => { + (false, Some(header_of_starting_fu_a)) => { let pieces = self.nal_parser.append_rtp_nal(data)?; - let header_of_starting_fu_a = access_unit.in_fu_a.expect( - "Nal header should be set because starting FU-A is processed before middle FU-A", - ); if u8::from(nal_header) != u8::from(header_of_starting_fu_a) { return Err(format!( "FU-A has inconsistent NAL type: {:?} then {:?}", @@ -511,7 +510,7 @@ impl Depacketizer { return Err("FU-A has MARK and no END".into()); } } - (false, false) => { + (false, None) => { if loss > 0 { self.nal_parser.clear(); self.input_state = DepacketizerInputState::Loss {