mirror of
https://github.com/helix-editor/helix.git
synced 2024-11-25 19:03:30 +04:00
c6b83368b3
This fixes an edge case for completing shellwords. With a file "a b.txt" in the current directory, the sequence `:open a\<tab>` will result in the prompt containing `:open aa\ b.txt`. This is because the length of the input which is trimmed when replacing with completion is calculated on the part of the input which is parsed by shellwords and then escaped (in a separate operation), which is lossy. In this case it loses the trailing backslash. The fix provided here refactors shellwords to track both the _words_ (shellwords with quotes and escapes resolved) and the _parts_ (chunks of the input which turned into each word, with separating whitespace removed). When calculating how much of the input to delete when replacing with the completion item, we now use the length of the last part. This also allows us to eliminate the duplicate work done in the `ends_with_whitespace` check. |
||
|---|---|---|
| .. | ||
| commands | ||
| keymap | ||
| ui | ||
| application.rs | ||
| args.rs | ||
| commands.rs | ||
| compositor.rs | ||
| config.rs | ||
| health.rs | ||
| job.rs | ||
| keymap.rs | ||
| lib.rs | ||
| main.rs | ||