helix-mirror/helix-term
Gokul Soumya a8b123fe17
Fix byte index error in signature help highlighting
The language server sends a char offset range within the
signature help label text to highlight as the current parameter,
but helix uses byte offset ranges for rendering highlights. This
was brought up in the [review of the original signature help PR][1],
but the ranges were being highlighted correctly, and there were no
out of bound or indexing panics. Turns out rust-analyzer was
[incorrectly sending byte offsets] instead of char offsets and this
made it seem like all was well and good with offsets in helix during
initial testing.

[1]: https://github.com/helix-editor/helix/pull/1755#discussion_r906715371
[2]: https://github.com/rust-lang/rust-analyzer/pull/12272
2022-07-29 14:31:21 +09:00
..
src Fix byte index error in signature help highlighting 2022-07-29 14:31:21 +09:00
tests Fix backwards selection duplication widening bug (#2945) 2022-07-05 07:51:15 +09:00
.gitignore Initial import. 2020-05-20 18:14:51 +09:00
build.rs publish a source tarball with version and grammars (#1875) 2022-03-29 14:34:19 +09:00
Cargo.toml build(deps): bump grep-searcher from 0.1.8 to 0.1.10 (#3101) 2022-07-19 11:24:03 +09:00