Skyler Hawthorne
9a406b569b
reduce LSP timeout to 3s
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
759d55cc81
fail if doc save sender is closed
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
e645804b0a
Editor::flush_writes returns an error
2022-10-18 22:31:39 -04:00
Blaž Hrastnik
52ba550098
Use flush_writes in application.close()
2022-10-18 22:31:39 -04:00
Blaž Hrastnik
2a43ee0164
doc.close() now unused
2022-10-18 22:31:39 -04:00
Blaž Hrastnik
1b6f7319cd
Wire up save_queue as a part of new_document rather than open
2022-10-18 22:31:39 -04:00
Blaž Hrastnik
55b50d9e83
Seems like this flush is unnecessary
2022-10-18 22:31:39 -04:00
Blaž Hrastnik
b155e861ad
Use a write_count to determine how many writes left to flush
2022-10-18 22:31:39 -04:00
Blaž Hrastnik
b0212b3611
Deduplicate flush_writes
2022-10-18 22:31:39 -04:00
Blaž Hrastnik
30c93994b5
Use a single save_queue on the editor
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
beb3427bfb
improve app close failure display
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
bf378e71b0
fix tests
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
31d1bbfddb
review comments
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
9e64974f13
remove Document::format_and_save
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
3f07885b35
document should save even if formatter fails
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
b530a86d1f
remove Callback::Compositor variant
...
To reduce likelihood of accidental discarding of important callbacks
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
b3fc31a211
move language server refresh to document saved event handler
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
af03df3413
fix write scratch buffer to file
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
18c32118b1
Save text in document saved events, use in status message
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
f82a551b98
Rename doc save event names to past tense
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
6cffc7f05d
Add note about log level for integration tests
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
57de4e6251
various fixes in write-all path
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
7b11e9ac69
fix erroneous write sender close
...
This was not distinguishing the error types when trying a receive on an empty
receiver, which was erroneously causing the sender to be closed when trying to
flush the writes when there were none
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
d544376590
reset idle timer for all events
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
e5fd5e2a9c
fix panic when view of pending write is closed
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
faa00d4cc3
increase LSP shutdown timeout
...
The Clang LAP takes a long time to shut down on Windows
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
8c667ef8de
factor editor event handling into function
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
aaa1450678
fix write-quit with auto format
...
write-quit will now save all files successfully even when there is auto
formatting
2022-10-18 22:31:39 -04:00
Skyler Hawthorne
c9418582d2
fix modified status with auto format
2022-10-18 22:31:38 -04:00
Skyler Hawthorne
cb23399dee
improve reliability of shutdown
2022-10-18 22:31:38 -04:00
Skyler Hawthorne
b8a07f7d15
add conditional noop render back
...
It makes it much slower without stubbing this out
2022-10-18 22:31:38 -04:00
Skyler Hawthorne
69c9e44ef2
update write-quit to wait for saves
2022-10-18 22:31:38 -04:00
Skyler Hawthorne
e1f7bdb1d2
fix buffer-close
2022-10-18 22:31:38 -04:00
Skyler Hawthorne
83b6042b97
fix(write): do not set new path on document until write succeeds
...
If a document is written with a new path, currently, in the event that
the write fails, the document still gets its path changed. This fixes
it so that the path is not updated unless the write succeeds.
2022-10-18 22:31:38 -04:00
Skyler Hawthorne
a5a93182cd
fix: buffer-close ensuring writes
...
Make sure buffer-close waits for the document to finish its writes.
2022-10-18 22:31:38 -04:00
Skyler Hawthorne
d706194597
chore(write): serialize write operations within a Document
...
The way that document writes are handled are by submitting them to the
async job pool, which are all executed opportunistically out of order. It
was discovered that this can lead to write inconsistencies when there
are multiple writes to the same file in quick succession.
This seeks to fix this problem by removing document writes from the
general pool of jobs and into its own specialized event. Now when a
user submits a write with one of the write commands, a request is simply
queued up in a new mpsc channel that each Document makes to handle its own
writes. This way, if multiple writes are submitted on the same document,
they are executed in order, while still allowing concurrent writes for
different documents.
2022-10-18 22:31:38 -04:00
Peter Phillips
faf0c521d1
Fix link to textobjects usage from keymap documentation ( #4357 )
2022-10-18 21:16:44 -05:00
Jonathan LEI
1a772d1b67
Fix deleting word from end of buffer ( #4328 )
2022-10-18 19:53:58 -05:00
zetashift
0c14d9f869
Add a first version of kanagawa theme ( #4300 )
2022-10-18 19:32:02 -05:00
Roberto Vidal
1f74cf45d4
display tree sitter scopes in a popup ( #4337 )
2022-10-19 00:00:00 +05:30
Philipp Mildenberger
d17ffc47f0
Use the same WalkBuilder configuration for the global search file picker as the default file picker ( #4334 )
...
Skip searching .git in global search, similar to how file picker skips listing files in .git.
2022-10-18 22:58:16 +05:30
dependabot[bot]
fee5db161b
build(deps): bump cachix/install-nix-action from 17 to 18 ( #4340 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-17 20:03:04 -05:00
dependabot[bot]
414214f883
build(deps): bump tokio-stream from 0.1.10 to 0.1.11 ( #4341 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-17 19:56:29 -05:00
dependabot[bot]
38746b04b4
build(deps): bump cachix/cachix-action from 10 to 11 ( #4339 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-17 19:55:15 -05:00
Clay
b07ef6bec3
Bump tree-sitter-elixir ( #4333 )
2022-10-18 01:05:14 +09:00
A-Walrus
8bbddf90ff
Replace in_bounds with calculation of end_indent
...
Instead of repeatedly checking if it is in_bounds, calculate the
max_indent beforehand and just loop. I added a debug_assert to "prove"
that it never tries drawing out of bounds.
2022-10-18 00:38:16 +09:00
A-Walrus
1de02a147c
Only draw indent guides within bounds
...
Better performance, and otherwise very long lines with lots of tabs
will wrap around the u16 and come back on the other side, messing up
the beginning skip_levels.
2022-10-18 00:38:16 +09:00
A-Walrus
2c36e33e0a
Make skip_levels a u8
2022-10-18 00:38:16 +09:00
A-Walrus
3ba665d804
Fix rendering of lines longer than 2^16
...
Before things would be cast to u16 earlier than needed, which would
cause problems for insanely long lines (longer than 2^16 ~ 65 thousand)
2022-10-18 00:38:16 +09:00
Gokul Soumya
4e691d6247
Change diagnostic picker keybind to <space>d ( #4229 )
...
Also changes workspace diagnostic picker bindings to <space>D and
changes the debug menu keybind to <space>g, the previous diagnostic
picker keybind. This brings the diagnostic picker bindings more in
line with the jump to next/previous diagnostic bindings which are
currently on ]d and [d.
2022-10-17 16:45:42 +09:00
