andrey/helix-mirror
1
0
Fork 0
mirror of https://github.com/helix-editor/helix.git synced 2024-11-22 01:16:18 +04:00
Code Issues Projects Releases Wiki Activity

Ignore SendErrors when handling grammars (#2641)

Browse Source 
When handling grammars, fetching and building is done in a thread
pool.  Results are communicated over channels and the receiving
channel is closed on first error. This causes subsequent sends to
fail causing a mess in stderr. This ignores all SendErrors causing
only the first error to be printed.
This commit is contained in:
Frojdholm 2022-06-02 09:54:11 +02:00 committed by GitHub
parent 378f438fb0
commit f7c27b604f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
helix-loader/src/grammar.rs
View File

@ -133,7 +133,9 @@ fn run_parallel<F>(grammars: Vec<GrammarConfiguration>, job: F, action: &'static
let tx = tx.clone();
pool.execute(move || {
tx.send(job(grammar)).unwrap();
// Ignore any SendErrors, if any job in another thread has encountered an
// error the Receiver will be closed causing this send to fail.
let _ = tx.send(job(grammar));
});
}