clippy lint

This commit is contained in:
Blaž Hrastnik 2020-10-23 13:51:08 +09:00
parent f5981f72c2
commit eff6fac9ec
5 changed files with 29 additions and 22 deletions

View File

@ -138,11 +138,10 @@ pub async fn recv_msg(&mut self, msg: Message) -> anyhow::Result<()> {
// println!("<- {} {:?}", method, notification); // println!("<- {} {:?}", method, notification);
self.incoming.send(notification).await?; self.incoming.send(notification).await?;
} }
Message::Call(call) => { Message::Call(_call) => {
// println!("<- {:?}", call); // println!("<- {:?}", call);
// dispatch // dispatch
} }
_ => unreachable!(),
}; };
Ok(()) Ok(())
} }

View File

@ -164,4 +164,6 @@ pub fn selection(&self) -> &Selection {
// pub fn slice<R>(&self, range: R) -> RopeSlice where R: RangeBounds { // pub fn slice<R>(&self, range: R) -> RopeSlice where R: RangeBounds {
// self.state.doc.slice // self.state.doc.slice
// } // }
// TODO: transact(Fn) ?
} }

View File

@ -12,6 +12,12 @@ pub struct Editor {
pub theme: Theme, // TODO: share one instance pub theme: Theme, // TODO: share one instance
} }
impl Default for Editor {
fn default() -> Self {
Self::new()
}
}
impl Editor { impl Editor {
pub fn new() -> Self { pub fn new() -> Self {
let theme = Theme::default(); let theme = Theme::default();

View File

@ -1,6 +1,6 @@
use crate::commands::{self, Command}; use crate::commands::{self, Command};
use crate::document::Mode; use crate::document::Mode;
use helix_core::{hashmap, state}; use helix_core::hashmap;
use std::collections::HashMap; use std::collections::HashMap;
// Kakoune-inspired: // Kakoune-inspired:

View File

@ -86,24 +86,24 @@ pub fn screen_coords_at_pos(&self, text: &RopeSlice, pos: usize) -> Option<Posit
Some(Position::new(row, col)) Some(Position::new(row, col))
} }
pub fn traverse<F>(&self, text: &RopeSlice, start: usize, end: usize, fun: F) // pub fn traverse<F>(&self, text: &RopeSlice, start: usize, end: usize, fun: F)
where // where
F: Fn(usize, usize), // F: Fn(usize, usize),
{ // {
let start = self.screen_coords_at_pos(text, start); // let start = self.screen_coords_at_pos(text, start);
let end = self.screen_coords_at_pos(text, end); // let end = self.screen_coords_at_pos(text, end);
match (start, end) { // match (start, end) {
// fully on screen // // fully on screen
(Some(start), Some(end)) => { // (Some(start), Some(end)) => {
// we want to calculate ends of lines for each char.. // // we want to calculate ends of lines for each char..
} // }
// from start to end of screen // // from start to end of screen
(Some(start), None) => {} // (Some(start), None) => {}
// from start of screen to end // // from start of screen to end
(None, Some(end)) => {} // (None, Some(end)) => {}
// not on screen // // not on screen
(None, None) => return, // (None, None) => return,
} // }
} // }
} }