andrey/helix-mirror
1
0
Fork 0
mirror of https://github.com/helix-editor/helix.git synced 2025-01-19 13:37:06 +04:00
Code Issues Projects Releases Wiki Activity

Fix panic when moving over unicode punctuation

Browse Source 
`is_ascii_punctuation` will only work for ASCII punctuations, and when
we have unicode punctuation (or other) we jump into the `unreachable`.
This patch fallback into categorizing everything in this branch as
`Unknown`.

Fixes https://github.com/helix-editor/helix/issues/123

https://github.com/helix-editor/helix/pull/135: add better support for
unicode categories.
This commit is contained in:
Benoît CORTIER 2021-06-05 12:01:20 -04:00 committed by Blaž Hrastnik
parent 16b1cfa3be
commit 8a29086c1a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
helix-core/src/movement.rs
View File

@ -188,7 +188,9 @@ pub(crate) enum Category {
Eol, Eol,
Word, Word,
Punctuation, Punctuation,
Unknown,
} }
pub(crate) fn categorize(ch: char) -> Category { pub(crate) fn categorize(ch: char) -> Category {
if ch == '\n' { if ch == '\n' {
Category::Eol Category::Eol
@ -199,7 +201,7 @@ pub(crate) fn categorize(ch: char) -> Category {
} else if ch.is_ascii_punctuation() { } else if ch.is_ascii_punctuation() {
Category::Punctuation Category::Punctuation
} else { } else {
unreachable!("unknown '{}' character category", ch) Category::Unknown
} }
} }