andrey/helix-mirror
1
0
Fork 0
mirror of https://github.com/helix-editor/helix.git synced 2024-11-22 09:26:19 +04:00
Code Issues Projects Releases Wiki Activity

only fetch git-sourced grammars

Browse Source 
This is a bit of a micro-optimization: in the current setup we waste
a thread in the pool for a local grammar only to println! a message
saying we're skipping fetching because it's a local grammar.
This commit is contained in:
Michael Davis 2022-02-19 04:51:14 -06:00 committed by Blaž Hrastnik
parent a229f405cc
commit 6fcab90d16
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
helix-loader/src/grammar.rs
View File

@ -76,7 +76,11 @@ pub fn get_language(name: &str) -> Result<Language> {
} }
pub fn fetch_grammars() -> Result<()> { pub fn fetch_grammars() -> Result<()> {
run_parallel(get_grammar_configs()?, fetch_grammar, "fetch") // We do not need to fetch local grammars.
let mut grammars = get_grammar_configs()?;
grammars.retain(|grammar| !matches!(grammar.source, GrammarSource::Local { .. }));
run_parallel(grammars, fetch_grammar, "fetch")
} }
pub fn build_grammars() -> Result<()> { pub fn build_grammars() -> Result<()> {
@ -172,15 +176,12 @@ fn fetch_grammar(grammar: GrammarConfiguration) -> Result<()> {
"Grammar '{}' checked out at '{}'.", "Grammar '{}' checked out at '{}'.",
grammar.grammar_id, revision grammar.grammar_id, revision
); );
Ok(())
} else { } else {
println!("Grammar '{}' is already up to date.", grammar.grammar_id); println!("Grammar '{}' is already up to date.", grammar.grammar_id);
Ok(())
} }
} else {
println!("Skipping local grammar '{}'", grammar.grammar_id);
Ok(())
} }
Ok(())
} }
// Sets the remote for a repository to the given URL, creating the remote if // Sets the remote for a repository to the given URL, creating the remote if