andrey/helix-mirror
1
0
Fork 0
mirror of https://github.com/helix-editor/helix.git synced 2024-11-22 01:16:18 +04:00
Code Issues Projects Releases Wiki Activity

use which on formatter command (#8064)

Browse Source
This commit is contained in:
Ezekiel Warren 2023-08-30 07:51:03 -07:00 committed by GitHub
parent 7fffc0a5d1
commit 6bef982f2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
helix-view/src/document.rs
View File

@ -733,16 +733,16 @@ pub fn auto_format(&self) -> Option<BoxFuture<'static, Result<Transaction, Forma
// We can't use anyhow::Result here since the output of the future has to be
// clonable to be used as shared future. So use a custom error type.
pub fn format(&self) -> Option<BoxFuture<'static, Result<Transaction, FormatterError>>> {
if let Some(formatter) = self
if let Some((fmt_cmd, fmt_args)) = self
.language_config()
.and_then(|c| c.formatter.clone())
.filter(|formatter| which::which(&formatter.command).is_ok())
.and_then(|c| c.formatter.as_ref())
.and_then(|formatter| Some((which::which(&formatter.command).ok()?, &formatter.args)))
{
use std::process::Stdio;
let text = self.text().clone();
let mut process = tokio::process::Command::new(&formatter.command);
let mut process = tokio::process::Command::new(&fmt_cmd);
process
.args(&formatter.args)
.args(fmt_args)
.stdin(Stdio::piped())
.stdout(Stdio::piped())
.stderr(Stdio::piped());
@ -751,7 +751,7 @@ pub fn format(&self) -> Option<BoxFuture<'static, Result<Transaction, FormatterE
let mut process = process
.spawn()
.map_err(|e| FormatterError::SpawningFailed {
command: formatter.command.clone(),
command: fmt_cmd.to_string_lossy().into(),
error: e.kind(),
})?;
{