Only write newlines in menu selection popup if the lsp returns detail (#4902)

This commit is contained in:
ath3 2022-12-09 04:55:15 +01:00 committed by GitHub
parent d914642089
commit 6798a6651f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -411,7 +411,7 @@ fn render(&mut self, area: Rect, surface: &mut Surface, cx: &mut Context) {
"```{}\n{}\n```\n{}", "```{}\n{}\n```\n{}",
language, language,
option.detail.as_deref().unwrap_or_default(), option.detail.as_deref().unwrap_or_default(),
contents.clone() contents
), ),
cx.editor.syn_loader.clone(), cx.editor.syn_loader.clone(),
) )
@ -421,15 +421,14 @@ fn render(&mut self, area: Rect, surface: &mut Surface, cx: &mut Context) {
value: contents, value: contents,
})) => { })) => {
// TODO: set language based on doc scope // TODO: set language based on doc scope
Markdown::new( if let Some(detail) = &option.detail.as_deref() {
format!( Markdown::new(
"```{}\n{}\n```\n{}", format!("```{}\n{}\n```\n{}", language, detail, contents),
language, cx.editor.syn_loader.clone(),
option.detail.as_deref().unwrap_or_default(), )
contents.clone() } else {
), Markdown::new(contents.to_string(), cx.editor.syn_loader.clone())
cx.editor.syn_loader.clone(), }
)
} }
None if option.detail.is_some() => { None if option.detail.is_some() => {
// TODO: copied from above // TODO: copied from above