mirror of
https://github.com/helix-editor/helix.git
synced 2024-11-22 09:26:19 +04:00
Address some PR comments.
This commit is contained in:
parent
01247acf0c
commit
5ee6ba5b38
@ -32,10 +32,9 @@ fn find_word_boundary(slice: RopeSlice, mut pos: usize, direction: Direction) ->
|
||||
if category != prev_category && pos != 0 && pos != slice.len_chars() {
|
||||
return pos;
|
||||
} else {
|
||||
if direction == Direction::Forward {
|
||||
pos += 1;
|
||||
} else {
|
||||
pos = pos.saturating_sub(1);
|
||||
match direction {
|
||||
Direction::Forward => pos += 1,
|
||||
Direction::Backward => pos = pos.saturating_sub(1),
|
||||
}
|
||||
prev_category = category;
|
||||
}
|
||||
|
@ -92,17 +92,17 @@ pub fn ensure_cursor_in_view(&mut self, doc: &Document) {
|
||||
let line = pos.row;
|
||||
let col = pos.col;
|
||||
let height = self.area.height.saturating_sub(1); // - 1 for statusline
|
||||
let last_line = self.first_line + height as usize;
|
||||
let last_line = (self.first_line + height as usize).saturating_sub(1);
|
||||
|
||||
let scrolloff = PADDING.min(self.area.height as usize / 2); // TODO: user pref
|
||||
|
||||
// TODO: not ideal
|
||||
const OFFSET: usize = 7; // 1 diagnostic + 5 linenr + 1 gutter
|
||||
let last_col = self.first_col + (self.area.width as usize - OFFSET);
|
||||
let last_col = (self.first_col + self.area.width as usize).saturating_sub(OFFSET + 1);
|
||||
|
||||
if line > last_line.saturating_sub(scrolloff + 1) {
|
||||
if line > last_line.saturating_sub(scrolloff) {
|
||||
// scroll down
|
||||
self.first_line += line - (last_line.saturating_sub(scrolloff + 1));
|
||||
self.first_line += line - (last_line.saturating_sub(scrolloff));
|
||||
} else if line < self.first_line + scrolloff {
|
||||
// scroll up
|
||||
self.first_line = line.saturating_sub(scrolloff);
|
||||
|
Loading…
Reference in New Issue
Block a user